search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 174 forks source link

Ignore replicas number in Deployment/Statefulset when using autoscaling #297

Closed alexaxms closed 2 years ago

alexaxms commented 2 years ago

Using replicas and HPA at same time can causes some troubles when reapplying some resources since it reset to replicas number.

Fixes # . Make replicas conditional on using HPA for workers

Changes proposed in this pull request

xtremerui commented 2 years ago

I think the changes are fine but do you have an example of the problem e.g. actual failure error, links or issues? Thx

alexaxms commented 2 years ago

I think the changes are fine but do you have an example of the problem e.g. actual failure error, links or issues? Thx

I was using ArgoCD with autosync and it never scaled up, usually all charts ignore replicas in Deployments when the HPA is enabled, I noticed that it won't scale because the replicas was setted at the same time as the HPA and ArgoCD is constantly applying the chart to maintain it healthy.

It can provides some unexpected behaviour if you apply changes and you are using it in prod since it resets to the replicas value everytime you upgrade the chart.