search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 174 forks source link

Bump concourse version to 7.7.1 #300

Closed wanderanimrod closed 2 years ago

wanderanimrod commented 2 years ago

Existing Issue

It is not an issue with the chart. We just need a new Concourse version with bug fixes.

Fixes

Concourse 7.7.0 (the latest version provided by this chart) has this terrible pipeline archiving bug. We need a version that fixes that bug, and that version is 7.7.1.

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
xtremerui commented 2 years ago

Hi, I think the PR should target branch dev.

wanderanimrod commented 2 years ago

@xtremerui, I thought that chart PRs that would release the latest version of Concourse are supposed to target master. This is the statement that led me to that conclusion (it is in the PR template)

master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately

concourse/concourse:latest on docker hub has this digest: 11c5f14bf512, and concourse/concourse:7.7.1 has the same digest. They were both pushed at the same time (16hours ago as of this writing), so I read this to mean that the latest version of Concourse on Dockerhub is 7.7.1.

Screen Shot 2022-05-12 at 9 52 06 AM Screen Shot 2022-05-12 at 9 51 49 AM

For these reasons, I thought that targeting master was the correct thing to do.

Am I misunderstanding something?

xtremerui commented 2 years ago

Sorry about this.

We had a PR merged into master mistakenly. So I was thinking putting yours into dev and we wait. But now I have managed to force push master to clean up the wrong commits so we are good here.

Could you rebase master again? Thx!

wanderanimrod commented 2 years ago

@xtremerui , thanks! I have rebased on master. Feel free to merge if it looks good to you.

xtremerui commented 2 years ago

Thank you for the PR. New version is now pushed to our chart index. Let us know if there is any problem.

wanderanimrod commented 2 years ago

Thank you!