concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

143 stars 174 forks source link

Use v1beta1 apiVersion for PSPs #315

Closed wiegandf closed 1 year ago

wiegandf commented 1 year ago

Existing Issue

Fixes https://github.com/concourse/concourse-chart/issues/310#issuecomment-1285342336.

Why do we need this PR?

policy/v1 doesn't contain PodSecurityPolicy, so this chart fails to install for all users that create a psp from the chart.

Changes proposed in this pull request

Revert relevant lines from https://github.com/concourse/concourse-chart/commit/ade9143b9c3d4c427fd9ddc71f7a3db377f4cdf1

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

xtremerui commented 1 year ago

Hi, thx for the fix. Indeed, if we want to keep PodSecurityPolicy, we must reverted to v1beta1. In the future, when we want to support 1.25 we will need to drop/replace it completely.