concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 176 forks source link

Fix postgreSQL persistence chart-values #319

Closed AndreasBurger closed 1 year ago

AndreasBurger commented 1 year ago

Why do we need this PR?

Currently some of the values intended to be used by the PostgreSQL-subchart do not have the correct structure. The subchart, as it is currently used, expects them at (.values).primary.persistence (checked both the in-use version 11.9.8 and the current version 12.1.9) but they are passed along simply at (.values).persistence. The relevant part of the PostgreSQL chart documentation can be found at https://artifacthub.io/packages/helm/bitnami/postgresql#postgresql-primary-parameters.

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
AndreasBurger commented 1 year ago

Also, this might hint at a simple resolution for issue #162 as the requested selector value is already part of/supported by primary.persistence.

xtremerui commented 1 year ago

Thank you for the PR! Could you rebase and also update this line to point to the current postgresql chart version?

AndreasBurger commented 1 year ago

I've updated the reference to point to the version that is currently in use (11.9.8) and also rebased the branch on the latest master.