concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 176 forks source link

Add labels to worker volumeClaimTemplate #322

Closed funkypenguin closed 1 year ago

funkypenguin commented 1 year ago

Why do we need this PR?

This PR adds support for applying labels to the PVCs created by the worker's statefulset, via volumeClaimTemplates. In some backup regimes, items are included / excluded from backups by virtue of their labels.

In my particular case, I don't want Velero to attempt to backup the workers' PVCs, so I need to add the velero.io/exclude-from-backup=true label to all the worker PVCs.

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
xtremerui commented 1 year ago

Hi, master branch is updated could you rebase? Thank you!

funkypenguin commented 1 year ago

Hi, master branch is updated could you rebase? Thank you!

I think I've rebased correctly, but I'd appreciate a careful check! :)

xtremerui commented 1 year ago

you will also need to fix the DCO status check by signing off your commits.

EDIT: you will need to rebase master into your branch otherwise it will create a hugh commit history list like now.

xtremerui commented 1 year ago

Close due to #333