concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 174 forks source link

Enable Port Name overrides on web-api-service #326

Open ibrahimparvez2 opened 1 year ago

ibrahimparvez2 commented 1 year ago

When deploying this chart with Istio ingress due to istio's convention which requires port names to be prefixed http- this subsequently results in needing to patch web-api-svc manifest post deployment.

Changes proposed in this pull request

This allows users to override the default names provided which eases the issues when using istio service mesh

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)