concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 174 forks source link

Concourse Helm Chart - Specify custom Worker Secrets name #345

Open jgifford25 opened 9 months ago

jgifford25 commented 9 months ago

Is your feature request related to a problem? Please describe.

When deploying two implementations of the Helm Chart in the same namespace, unable to share a single worker secret between the two deployments.

Describe the solution you'd like

In worker-deployment.yaml and worker-statefulset.yaml, the worker secrets are configured as a named volume as such:

secretName: {{ template "concourse.worker.fullname" . }}

Unfortunately, the above uses a helm template function and the secret name is autogenerated by that function is not configurable nor overridable through the values.yaml or as overrides in the helm chart execution. And if you do override the name to match, name conflicts with the deployment of the Helm chart will ensue.

In our case, we're deploying two (2) groups of workers that are configured very differently (i.e. Windows vs. Unix), and since we already have our worker-secrets configured AND stored outside of the first helm chart, it would be advantageous to share the same secret instead of duplicating it for the second Helm Chart installation. Even another user who has two deployments of Concourse workers via Helm might want to share the secret configuration auto-generated by the first Helm Chart with the second Helm Chart deployment.

The solution would be to allow a custom value to override the secret name created by the helm chart template function.

Describe alternatives you've considered

No response

Additional context

No response