search

concourse / concourse-docker

Offical concourse/concourse Docker image.
Apache License 2.0
241 stars 152 forks source link

Set various env vars for keys only for the appropriate command (`web` or `worker`) #58

Closed vito closed 4 years ago

vito commented 4 years ago

Related: https://github.com/concourse/concourse/pull/5491

Currently we configure all the env vars unconditionally:

https://github.com/concourse/concourse-docker/blob/3a4ac97feeea862d66cd513634b44b78903d0991/Dockerfile#L10-L17

This is a handy shortcut but no longer works now that we've modified go-flags to actually perform validation against env vars.

For backwards compatibility, it would be nice to preserve these default values (ha, I guess we're using them that way after all). Maybe we can do so by having an entrypoint that sets the appropriate vars based on the command being run?