concourse / concourse-docker

Offical concourse/concourse Docker image.
Apache License 2.0
241 stars 152 forks source link

Correct usage of no authentication parameter in web #8

Closed elgohr closed 6 years ago

elgohr commented 6 years ago

Changes the CONCOURSE_NO_REALLY_I_DONT_WANT_ANY_AUTH-parameter usage to the same like in docker-compose-quickstart.yml Without the equals true, the parameter is not used and an error occurs on startup:

concourse-web_1 | 1 error occurred: concourse-web_1 | concourse-web_1 | * must configure basic auth, OAuth, UAAAuth, or provide no-auth flag concoursedocker_concourse-web_1 exited with code 1

vito commented 6 years ago

This is intentional. It's there to be overridden - either that var or basic auth. The quickstart compose file sets it because it's meant for kicking the tires. It's not safe to assume as much with the normal compose file, so I don't want people to end up with wide-open Concourse installations by default.

Thanks though!

elgohr commented 6 years ago

Did I miss the documentation for this intention?