concourse / concourse-docker

Offical concourse/concourse Docker image.
Apache License 2.0
241 stars 152 forks source link

Apply shellcheck fixes to entrypoint.sh #80

Closed arulagrawal closed 2 years ago

arulagrawal commented 2 years ago

Applied shellcheck's recommendations to entrypoint.sh as I was trying to get around the cgroup issue in my own image.

I think the fix on line 2 is particularly needed since comparison with == is not correct in posix, and dash throws an error here. Pretty sure this results in lines 4 and 5 not executing.

Since the default image uses Ubuntu (and therefore dash) I think this fix is necessary for the cgroup v2 fix to actually apply.