search

concourse / concourse-pipeline-resource

!!! use the `set_pipeline` step instead !!!
https://concourse-ci.org/jobs.html#schema.step.set-pipeline-step.set_pipeline
MIT License
76 stars 41 forks source link

Convert insecure to boolean #18

Open o-orand opened 7 years ago

o-orand commented 7 years ago

Hello, Back in 2016, concourse only supported string variable (to be able to set it using a var file), but now since 3.2.0 we have strings, boolean values, arrays. So rather than putting string everywhere, it could be better to convert insecure to boolean ? But it is going to break compatibility with previous version. What do you think ?

robdimsdale commented 7 years ago

This is something I touched on in #16; thanks for raising it explicitly in its own issue.

In principle I think switching from string type to boolean type for insecure (and any other boolean types) is a good idea as it is more intuitive. However, it will break existing users and there isn't a consistent pattern for distributing versioned resources. What I mean by this is that if we update the existing docker image under latest-final tag we force the breaking change on all users, but instead if we make a docker image under a new tag without updating the existing latest-final tag it isn't very discoverable.

Perhaps now is a good time to switch to deprecating the latest-final tag in favor of a more obvious versioning scheme (i.e. v1 and v2)?

Or we could force the breaking change on all users and avoid this extra complexity.

cc @chendrix

o-orand commented 7 years ago

It could be nice to introduce a new versioning scheme, to replace latest-final. It is possible to set v1 to latest-final, so it's still working for "old" users who don't want/require upgrade. Switching tag from latest-final to v2 doesn't sound to complex for users who want to use the latest release 😄.

robdimsdale commented 7 years ago

I'd be in favor of a better versioning scheme for third-party resources, and I'd really like to see all third-party resources adopt the same convention. One way to achieve this could be to call out a specific convention in the concourse docs on this topic.

jtarchie commented 7 years ago

@o-orand was there any update to this?

o-orand commented 7 years ago

@jtarchie sorry, not on my side...