search

concourse / concourse-pipeline-resource

!!! use the `set_pipeline` step instead !!!
https://concourse-ci.org/jobs.html#schema.step.set-pipeline-step.set_pipeline
MIT License
76 stars 42 forks source link

Allow pipeline variables to be passed in via params #48

Closed peterellisjones closed 5 years ago

peterellisjones commented 5 years ago

relates to: https://github.com/concourse/concourse-pipeline-resource/issues/9 https://www.pivotaltracker.com/n/projects/1549921/stories/117033587 https://www.pivotaltracker.com/n/projects/1549921/stories/117501261

Allows variables to be passed to pipelines in the following manner:

jobs:
- name: put-all-pipelines
  plan:
  - get: all-pipelines
    params:
      pipelines:
      - name: pipeline-1
        config_file: files/pipeline-1.yml
        vars:
          var1: val1
          var2: val2

All unit tests pass. Acceptance tests (which are skipped using the Docker build method) pass for the out and check command. From what I can tell, the in command "target not provided = exit 1" test is failing on master because when the test removes the target, this code sets a default anyway.

vito commented 5 years ago

Looks good, thanks!

DanielJonesEB commented 5 years ago

Hey folks - when will this be released, do you think? We've got a self-setting pipeline that breaks without this. I didn't check to see if the README was in sync with the version we're using :)

https://github.com/EngineerBetter/concourse-up/commit/2979ee0ca6ce076e4009030dd6bbce5c9e66edee

vito commented 5 years ago

@DanielJonesEB shipping it now as v1.1