search

concourse / concourse-pipeline-resource

!!! use the `set_pipeline` step instead !!!
https://concourse-ci.org/jobs.html#schema.step.set-pipeline-step.set_pipeline
MIT License
76 stars 42 forks source link

moves dockerfiles to separate folder #52

Closed chenbh closed 5 years ago

chenbh commented 5 years ago

Should be merged as same time as concourse/concourse#3364

vito commented 5 years ago

I don't think we need to build Ubuntu images for this resource; it's not packaged as part of the core and it's not packaged for PCF either. I can re-open if that situation has changed.

chenbh commented 5 years ago

@vito this is included in the https://github.com/concourse/concourse/blob/master/ci/pipelines/resources/resources file which means it will be run through the template.jsonnet and expect multiple dockerfiles

Same issue exists for mock and datadog-event resources

chenbh commented 5 years ago

whoops didn't see your comment in the parent issue, gonna keep the conversation there instead

vito commented 5 years ago

@chenbh :+1: gotcha. in that case it looks like this just needs to be rebased

chenbh commented 5 years ago

@vito done! I've asked @cirocosta to review this as he seems to be reviewing the other resource PRs as well