Only output the handled pipelines in the metadata of Out.

concourse / concourse-pipeline-resource

!!! use the `set_pipeline` step instead !!!

https://concourse-ci.org/jobs.html#schema.step.set-pipeline-step.set_pipeline

MIT License

76 stars 42 forks source link

Only output the handled pipelines in the metadata of Out. #58

Closed aledegano closed 5 years ago

aledegano commented 5 years ago

The metadata of Out now only loops over the pipelines defined in the Out parameters instead of looping over all the pipelines of the given team, reducing the clutter displayed on the job.

The test case for the Pipelines fly command is also removed from the Out test as it's no longer called.

Signed-off-by: Alessandro Degano alessandro.degano@pix4d.com

marco-m commented 5 years ago

@aledeganopix4d could you please post a screenshot of without and with this change ? I think this will make it easier for the reviewers to see the enhancement that this PR brings.

aledegano commented 5 years ago

In this example I'm setting a single pipeline, with the current version of the resource we have: before and the result of this PR is: after

marco-m commented 5 years ago

This fixes #53.

vito commented 5 years ago

Thanks!

aledegano commented 5 years ago

@vito Thank you for merging this and #56, could you please consider releasing at your earliest convenience?