concourse / github-release-resource

a resource for github releases
Apache License 2.0
56 stars 58 forks source link

put of github-release fails with concourse 7.5.0 #112

Open HemangLavana opened 3 years ago

HemangLavana commented 3 years ago

I have a put step of github release which fails with concourse 7.5.0 with the following error:

error running command: Field 'databaseId' doesn't exist on type 'Release'

If I downgrade back to 7.4.0, the same pipeline works.

Here's the part of the job that fails:

  - name: publish-release
    public: true
    plan:
      - in_parallel:
          - get: ws.ng-devops
          - get: version.python
            passed: [promote-python-image]
            trigger: true
      - put: release-python.ng-devops
        params:
          name: version.python/version
          tag: version.python/version
    on_failure: *send_email_on_failure

version.python is a semver resource. I have also filed https://github.com/concourse/concourse/discussions/7612, but I suspect this issue belongs here.

Let me know if you need more details.

taylorsilva commented 3 years ago

7.5.0 shipped with https://github.com/concourse/github-release-resource/releases/tag/v1.6.4 7.4.0 shipped with https://github.com/concourse/github-release-resource/releases/tag/v1.6.2

I would guess something from this commit was the issue? https://github.com/concourse/github-release-resource/commit/de55db24d0a22100d1bd69e663bbb2557bcd5e7b

What error message does it fail with?

HemangLavana commented 3 years ago

I am copying the exact error message once again below here:

error running command: Field 'databaseId' doesn't exist on type 'Release'

Looking at the release notes of 1.6.4, I found this:

  * Add databaseId field to Github graphql model. If that field is not present it will falls back to ID.

So I suppose, it is related to addition of the databaseId field and it doesn't seem to default back to ID when it is missing. Also the testcases doesn't seem to have the scenario where databaseId doesn't exist.

Note that my job is interacting with enterprise github (NOT github.com) and its version is: GitHub Enterprise Server 2.22.10. So it may be running older version of Github.

kirillbilchenko commented 3 years ago

@HemangLavana the similar issue https://github.com/concourse/github-release-resource/issues/109 for this one, need to be added one more model which will fallback for cases with enterprise server.