concourse / hush-house

Concourse k8s-based environment
https://hush-house.pivotal.io
30 stars 23 forks source link

Ensure jaeger-related pods don't land in worker node pools #123

Open cirocosta opened 4 years ago

cirocosta commented 4 years ago

Despite us having added nodeSelector to values.yaml there (see https://github.com/concourse/hush-house/commit/fe870da79fe6b1d30a044e5fa7d3ffc513915da7), it seems like we didn't really do it right - looking at jaeger's pod, it's not really in a node from the generic-1 pool:

Node:           gke-hush-house-workers-3-687beb5a-cv4c/10.10.0.63

That is a problem as we've been considering the worker pools to be reserved only for Concourse workers as Concourse will take care of containers by itself.

We could do so by either ensuring that nodeSelector is really properly specified in the right way, or perhaps adopting a different pattern, leveraging taints and tolerations (https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/)