search

concourse / pool-resource

atomically manages the state of the world (e.g. external environments)
Apache License 2.0
56 stars 36 forks source link

Always print when we are starting #42

Closed marco-m closed 5 years ago

marco-m commented 6 years ago

Always print a line to the log when starting. This allows to know when we started long-running operations (for example, waiting to acquire a lock).

Fixes #41

(see #41 for before and after screenshots of the problem)

pivotal-issuemaster commented 6 years ago

@marco-m Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 6 years ago

@marco-m Thank you for signing the Contributor License Agreement!

aegershman commented 6 years ago

I think this is a great idea and I know my team would get use out of this. Any plans on updating this PR?

marco-m commented 6 years ago

@aegershman I hope I will have time to update the PR this week.

marco-m commented 5 years ago

@vito I updated the PR as requested.

If you are happy, feel free to squash merge, I left the previous attempt only to compare during the lifetime of the PR.

While at it, I also changed the claim and update commands to behave in the same way as acquire. I updated #41 with the new screenshots.

I tested both the acquire and claim cases. I was not able to test the update case because I don't understand, from the documentation, how to actually use it. I will open a separate ticket