Make depth of 1 to be the default

concourse / pool-resource

atomically manages the state of the world (e.g. external environments)

Apache License 2.0

57 stars 36 forks source link

Make depth of 1 to be the default #52

Closed sc68cal closed 4 years ago

sc68cal commented 4 years ago

How do we get the DCO job to recheck? I force pushed a new commit with the added signoff

sc68cal commented 4 years ago

OK I guess I'll rebase & squash, and add you as a co-author, then force push. 🤷‍♂️

jamieklassen commented 4 years ago

@sc68cal the DCO check is still not passing. Is it possible github is doing something funny? When I look at the last two commits on your branch, they have no Signed-off-by line in the commit message, and in order for the check to pass they will need to contain

Signed-off-by: Sean M. Collins <sean@coreitpro.com>

sorry for the hassle!

sc68cal commented 4 years ago

rebased and added signoffs.

sc68cal commented 4 years ago

I'm actually going to fixup the commit messages that the github UI generated - I don't like them

sc68cal commented 4 years ago

ok, this should be good to merge