concourse / pool-resource

atomically manages the state of the world (e.g. external environments)
Apache License 2.0
57 stars 36 forks source link

basename: missing operand #54

Closed elgohr closed 4 years ago

elgohr commented 4 years ago

Introduced by https://github.com/concourse/pool-resource/commit/542a82c65f887db32af52e5cddc178cfbc73623b we got the following error with Concourse 6.3.0:

Cloning into '/tmp/build/get'...
d706a9f myJob build 163 unclaiming: development
fatal: ambiguous argument 'HEAD~1': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
basename: missing operand
Try 'basename --help' for more information.

We're using an ophan branch for tracking the pools.

Workaround

Set depth manually to some bigger value

- get: development
  resource: env-pool
  params:
     depth: 30
- put: env-pool
  params: {release: development}
  get_params:
     depth: 30

Possible Fix

Revert https://github.com/concourse/pool-resource/commit/542a82c65f887db32af52e5cddc178cfbc73623b

rahulkj commented 4 years ago

yeah please revert this 542a82c

vito commented 4 years ago

Reverted and shipped as ~v1.1.2~ v1.1.3:

resource_types:
- name: pool
  type: registry-image
  source: {repository: concourse/pool-resource, tag: 1.1.3}