search

concourse / pool-resource

atomically manages the state of the world (e.g. external environments)
Apache License 2.0
54 stars 36 forks source link

Revert "Make depth of 1 to be the default" #56

Closed vito closed 4 years ago

vito commented 4 years ago

Reverts concourse/pool-resource#52

fixes #54 fixes #55

Making the clone too shallow breaks the HEAD~1 comparison and also likely breaks the git checkout of the specified ref.

I'm not sure there's a sane default for the depth parameter, really. We faced this same problem with the git resource and ended up implementing a pretty complicated "deepening" loop.

coffee-squirrel commented 4 years ago

@vito Would a v6.3.1 Concourse release including pool-resource v1.1.3 be an option? We're trying to determine if we need to add a custom resource type to our remaining pipelines.

vito commented 4 years ago

@coffee-squirrel I think it would be better to add it your pipelines rather than waiting on a new Concourse version. It'll make your pipelines more self-contained, especially in light of concourse/rfcs#30 (we don't want to be bundling these resource types with Concourse forever).

I shared a snippet here: https://github.com/concourse/pool-resource/issues/54#issuecomment-645474399