concourse / pool-resource

atomically manages the state of the world (e.g. external environments)
Apache License 2.0
56 stars 36 forks source link

Claimed lock and then git 128 error - should go back into waiting state #72

Open sc68cal opened 3 months ago

sc68cal commented 3 months ago

Describe the bug

claiming lock on: environments

waiting for lock

................................

claimed!

error claiming lock: exit status 128

I think this is because two jobs raced each other and one won by pushing to the git repository, so the one that lost should have gone back into the waiting condition instead of throwing an error

Reproduction steps

Race condition

Expected behavior

The job that failed should maybe have been able to retry itself and try and acquire the lock again

Additional context

No response

sc68cal commented 3 months ago

The job that had won the race logged:

claiming lock on: environments

waiting for lock

...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

claimed!