search

concourse / prod

bosh/terraform config for our deployments
3 stars 5 forks source link

Adds key for platform-insights external workers #27

Closed klakin-pivotal closed 5 years ago

klakin-pivotal commented 5 years ago

DCO bot says:

Commit sha: 6a280fb, Author: Kenneth Lakin, Committer: GitHub; The sign-off is missing.

Do I seriously need to add a signoff for my own commit?

cirocosta commented 5 years ago

Hey @klakin-pivotal , yeah. you still need to do it 😬

vito commented 5 years ago

@klakin-pivotal Yes, that's how every DCO process works. There are instructions detailed in the failing check that you can literally just copy-paste. It only takes a second to follow.

In this case we can just skip it. I don't think we need to apply DCO to this repo as there's not really any code to license here in the first place. It's just config. The DCO bot is only kicking in here because we have it enabled on across the entire organization so we don't forget it in any new repos.

klakin-pivotal commented 5 years ago

Yes, that's how every DCO process works.

I would have expected that me submitting a PR (sign-off #2) containing a single commit that I authored (sign-off #1) would have been enough signoffs to signal Developer Consent. :heart:

Anyway, I would have added sign-off #3 on Friday, but I only just got back into the office today. Thanks much for merging this in! :)