concourse / registry-image-resource

a resource for images in a Docker registry
Apache License 2.0
89 stars 107 forks source link

Add AWS Instance Profile authentication support for AWS ECR #297

Closed jimmyR closed 3 years ago

jimmyR commented 3 years ago

Following AWS Best Practice, we use Instance Profiles on our EC2 nodes that run concourse.

By avoiding passing Credentials to the aws.Config, it allows the registry-image-resource to use Instance Profiles authentication, so we can avoid having to create and manages access keys.

aoldershaw commented 3 years ago

Hi, thanks for the PR, but unfortunately I don't think we'll accept it. For some context as to why, refer to https://github.com/concourse/registry-image-resource/pull/287#issuecomment-876483708, but to try and summarize:

If you need this behaviour for the time being, and are okay with the implications outlined in the linked comment, than you can push an image based on your fork and use that as a custom resource_type