search

concourse / registry-image-resource

a resource for images in a Docker registry
Apache License 2.0
89 stars 107 forks source link

Still apply "latest" tag when using "additional_tags" option #331

Closed imsodin closed 1 year ago

imsodin commented 1 year ago

We tag our images with the git sha, and to do that I used the additional_tags option which works fine. However what surprised me and caused some debugging is, that they aren't really "additional": Only those tags are created, i.e. no "latest" tag which is otherwise the default and the "additional" part kinda implies that they aren't exclusive. I'd propose to always add the "latest" (or otherwise configured) tag as well. Or otherwise I propose to make it more explicit in the readme that exclusively the additional tags are used. If you desire no behaviour change, please let me know and I'll make a PR proposing the changes to the readme.

imsodin commented 1 year ago

Actually never mind, the current behaviour gives more control to the user, so I believe that's benefitial. I'll open a PR to clarify. Sorry for the noise.