concourse / registry-image-resource

a resource for images in a Docker registry
Apache License 2.0
89 stars 107 forks source link

fix flakey check tests #357

Closed taylorsilva closed 5 months ago

taylorsilva commented 5 months ago

At some point when adding these tests, we forgot that maps in Go do not guarantee that the order items are added is the order they'll appear in when iterating over the map: https://go.dev/blog/maps (see very last section)

This commit changes the Tags input into a slice, which does have a guaranteed order when iterating over.

Ran the tests locally many times and am no longer getting seeing any flakiness.

xtremerui commented 5 months ago

thank you @taylorsilva !