search

concourse / resource-types-website

Website for Concourse resource types (Beta)
https://resource-types.concourse-ci.org
Apache License 2.0
9 stars 28 forks source link

DRAFT: Api data, footer, router, terms, index assets #162

Closed jomsie closed 4 years ago

jomsie commented 4 years ago

Bishoy, hello!

Buy a house yet?

Here are my ramblings about things that need to be done for: https://github.com/concourse/dutyfree/issues/99 https://github.com/concourse/dutyfree/issues/60 https://github.com/concourse/dutyfree/issues/156 https://github.com/concourse/dutyfree/issues/82

API Data: Mostly in Main.elm Todo: Bring in the backend changes, change the api url to the real server.

Footer: Mostly in Footer/ Todo: Get it to be stuck to the bottom when there is a spinner... That'll be in Main.elm, I think the spinner div needs a height fill.

Router: Mostly in Main.elm Todo: Tests D: Also it broke some tests (commented out) in MainTests.elm (due to Nav key).

Terms: Mostly in Terms/ Todo: Styling

Index Assets: Mostly in index.html Todo: Bring in the assets function.

Also todo: Banner: Mostly in Banner/ Todo: Get the new assets from here

So I also updated the readme with steps i use to run the server locally. Once you get the Go stuff working, that'll probably change quite a bit.

Good references!!!

Api: https://elmprogramming.com/retrieving-data-on-initialization.html

Router: https://elm.christmas/2018/15 https://package.elm-lang.org/packages/elm/browser/latest/Browser-Navigation#Key https://guide.elm-lang.org/webapps/navigation.html

Elm-UI in general: https://package.elm-lang.org/packages/mdgriffith/elm-ui/latest/Element

Also, run yarn analyse -s and go to http://localhost:3000/messages for help!