Packaging - Githubissues

concourse / resource-types-website

Website for Concourse resource types (Beta)

https://resource-types.concourse-ci.org

Apache License 2.0

9 stars 28 forks source link

Packaging #176

Closed YoussB closed 4 years ago

YoussB commented 4 years ago

This PR adds the first step towards making the website container ready and also k8s ready.

This PR:

Adds a Dockerfile that builds the whole code and then creates an image out of the built code. to run this image just run docker build -t dutyfree . && docker run dutyfree -p 9090:9090 and there it will run.
Adds a docker-compose.yml file to easily run a development environment.
Adds a helm chart that wraps the whole image in order to run the website on k8s. the chart is a bit more oriented towards gke at the moment.

cirocosta commented 4 years ago

The changes look good in overall :grin: happy to see this going forward!

One thing I couldn't figure out though:

Is the goal of the chart to have it shared with other folks, or just for internal consumption (i.e., for our own deployment?)

If the latter, it might be worth getting rid of some of the extra customizations that we might not need right now (e.g., podSecurityContext, etc). Wdyt?

thanks!

YoussB commented 4 years ago

@cirocosta It is currently for internal consumption, with no current intention for external use, but I didn't want to remove things that might come in handy at some point.

YoussB commented 4 years ago

@cirocosta @taylorsilva I think I have everything covered now. Let me know if it looks good now or there are more comments to address?