concourse / resource-types-website

Website for Concourse resource types (Beta)
https://resource-types.concourse-ci.org
Apache License 2.0
9 stars 28 forks source link

build(deps): bump mdgriffith/elm-ui from 1.1.7 to 1.1.8 in /web #239

Closed dependabot-preview[bot] closed 4 years ago

dependabot-preview[bot] commented 4 years ago

Bumps mdgriffith/elm-ui from 1.1.7 to 1.1.8.

Commits
  • 7aa0e01 1.1.8 - Checkbox accessibility fix. Checkbox positioning issue fix. Column c...
  • 2b66d51 resolves #235 - defaultCheckbox alignment would change if it was in a paragra...
  • 6ecd303 allow thumb to show focusable styles again
  • b5212f5 resolves #247 - button should respond to spacebar as well as enter. Also mov...
  • 18fb463 resolves #236 - checkboxes need proper markup to be read correctly by screen ...
  • 2dcbb80 add some more examples to test suite
  • 42d0dae resolves #203, does not regress #147, and sheds some other light on stuff
  • See full diff in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
jomsie commented 4 years ago

"Checkbox accessibility fix and column children sizing fix"

I'll take a quick look at this later today to see if any sizing issues occurred!

jomsie commented 4 years ago

There is a nice problem.

elm-ui 1.17

Screen Shot 2020-08-04 at 2 05 45 PM

elm-ui 1.18

Screen Shot 2020-08-04 at 2 05 53 PM

Our resource type names are gone!

Gonna start lookin around here: https://github.com/mdgriffith/elm-ui/commits/1.1.8, specifically https://github.com/mdgriffith/elm-ui/commit/42d0dae608c03a9bc340cf5194555ba2403869ee

jomsie commented 4 years ago

I'm going to use my powers and just merge this, if it breaks anything, I take full responsibility. @YoussB feel free to look at this and shame me next week!