concourse / s3-resource

Concourse resource for interacting with AWS S3
Apache License 2.0
62 stars 106 forks source link

Support bzip2 archive #81

Open jake-at-work opened 7 years ago

jake-at-work commented 7 years ago

Please consider support for tar with bzip2 compression format for archives.

jtarchie commented 7 years ago

@pivotal-jbarrett, are you able to make a PR for it? It looks like it should just be this file.

tracyde commented 7 years ago

It seems that a .tar.bz2 will still only count as a compressed application/x-bzip2 not an application/x-tar archive. The same issue will arise with (.tar.gz || .tgz) files.

It's still possible, but would have to do an internal select on file extension to make it happen in the inflate, and pass the file ext to the inflate function.

@jtarchie does that approach sound ok?