search

concourse / semver-resource

automated semantic version bumping
Apache License 2.0
97 stars 105 forks source link

replaced godep with modules. #107

Closed siennathesane closed 4 years ago

siennathesane commented 4 years ago

godep is an archived project, and they reference moving to dep, which was superseded by modules support.

This does not change any vendored dependencies, only migrates from godep to modules at whatever version the vendored dependencies were. Running go mod init github.com/concourse/semver-resource brought in all the dependencies at the versions they were referenced.

This change came about because I was working on adding a new driver and this was an easy update that needed to happen at some point soon.

Signed-off-by: Mike Lloyd mike@reboot3times.org

siennathesane commented 4 years ago

I thought there would be CI checks, but I guess not. I ran both tests:

docker build -t semver-resource -f dockerfiles/alpine/Dockerfile .
docker build -t semver-resource -f dockerfiles/ubuntu/Dockerfile .

and they passed successfully.

> docker build -t semver-resource -f dockerfiles/ubuntu/Dockerfile .
Sending build context to Docker daemon  11.84MB
Step 1/26 : FROM concourse/golang-builder as builder
 ---> ba8c72fecb17
Step 2/26 : COPY . /go/src/github.com/concourse/semver-resource
 ---> c068ef0623d2
Step 3/26 : ENV CGO_ENABLED 0
 ---> Running in 62eb2caac8a9
Removing intermediate container 62eb2caac8a9
 ---> fa08b5b182f7
Step 4/26 : RUN go build -o /assets/in github.com/concourse/semver-resource/in
 ---> Running in 59d884aee274
Removing intermediate container 59d884aee274
 ---> 1adaed60f443
Step 5/26 : RUN go build -o /assets/out github.com/concourse/semver-resource/out
 ---> Running in dcc83c21a346
Removing intermediate container dcc83c21a346
 ---> eaac8b4de5df
Step 6/26 : RUN go build -o /assets/check github.com/concourse/semver-resource/check
 ---> Running in 37f09e288d24
Removing intermediate container 37f09e288d24
 ---> 03e2af9877d5
Step 7/26 : WORKDIR /go/src/github.com/concourse/semver-resource
 ---> Running in f260b5e5f3c3
Removing intermediate container f260b5e5f3c3
 ---> 552b2a47fec8
Step 8/26 : RUN set -e; for pkg in $(go list ./...); do                 go test -o "/tests/$(basename $pkg).test" -c $pkg;      done
 ---> Running in 8cceee63fd3b
go: downloading github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: downloading google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: downloading github.com/aws/aws-sdk-go v1.8.35
go: downloading github.com/blang/semver v2.1.0+incompatible
go: extracting github.com/blang/semver v2.1.0+incompatible
go: extracting github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: downloading cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: downloading github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: extracting github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: extracting cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: extracting google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: extracting github.com/aws/aws-sdk-go v1.8.35
go: downloading google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: downloading golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: downloading github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: extracting github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: extracting google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: extracting golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: downloading github.com/golang/protobuf v1.3.1
go: downloading golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: downloading google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: downloading github.com/go-ini/ini v1.8.6
go: extracting golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: downloading golang.org/x/text v0.3.2
go: extracting github.com/go-ini/ini v1.8.6
go: downloading github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: extracting github.com/golang/protobuf v1.3.1
go: extracting github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: extracting google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: extracting golang.org/x/text v0.3.2
go: finding cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: finding github.com/blang/semver v2.1.0+incompatible
go: finding golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: finding google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: finding github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: finding github.com/golang/protobuf v1.3.1
go: finding google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: finding github.com/aws/aws-sdk-go v1.8.35
go: finding github.com/go-ini/ini v1.8.6
go: finding github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: finding golang.org/x/text v0.3.2
go: finding google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: finding github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: finding golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: finding github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: downloading github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: downloading github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
go: downloading github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: extracting github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: extracting github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
go: extracting github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: finding github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: finding github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: finding github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
?       github.com/concourse/semver-resource/models     [no test files]
Removing intermediate container 8cceee63fd3b
 ---> 9bd0be29abe9
Step 9/26 : FROM ubuntu:bionic AS resource
 ---> 775349758637
Step 10/26 : RUN apt-get update       && DEBIAN_FRONTEND=noninteractive       apt-get install -y --no-install-recommends         tzdata         ca-certificates
   git         jq         openssh-client       && rm -rf /var/lib/apt/lists/*
 ---> Using cache
 ---> 3c135cc3474d
Step 11/26 : RUN git config --global user.email "git@localhost"
 ---> Using cache
 ---> 8700b28abcf1
Step 12/26 : RUN git config --global user.name "git"
 ---> Using cache
 ---> 905082ef7dc6
Step 13/26 : COPY --from=builder assets/ /opt/resource/
 ---> Using cache
 ---> 9d576c0daf7a
Step 14/26 : RUN chmod +x /opt/resource/*
 ---> Using cache
 ---> c6d7a2306348
Step 15/26 : FROM resource AS tests
 ---> c6d7a2306348
Step 16/26 : ARG SEMVER_TESTING_ACCESS_KEY_ID
 ---> Using cache
 ---> 8921028053a5
Step 17/26 : ARG SEMVER_TESTING_SECRET_ACCESS_KEY
 ---> Using cache
 ---> 574a9d37c9aa
Step 18/26 : ARG SEMVER_TESTING_BUCKET
 ---> Using cache
 ---> 183f1d0de22c
Step 19/26 : ARG SEMVER_TESTING_REGION
 ---> Using cache
 ---> 5f30104d8715
Step 20/26 : ARG SEMVER_TESTING_V2_SIGNING
 ---> Using cache
 ---> e7ff4a7b27b7
Step 21/26 : COPY --from=builder /tests /go-tests
 ---> Using cache
 ---> 8cb2d099ce2d
Step 22/26 : WORKDIR /go-tests
 ---> Using cache
 ---> 8ac25314be9b
Step 23/26 : RUN set -e; for test in /go-tests/*.test; do               $test;  done
 ---> Using cache
 ---> 67f994a1802a
Step 24/26 : COPY test/ /opt/resource-tests
 ---> Using cache
 ---> 358174cf86ea
Step 25/26 : RUN /opt/resource-tests/all.sh
 ---> Using cache
 ---> 4fb75ced5e92
Step 26/26 : FROM resource
 ---> c6d7a2306348
Successfully built c6d7a2306348
Successfully tagged semver-resource:latest
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-x
r-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.
> docker build -t semver-resource -f dockerfiles/alpine/Dockerfile .
Sending build context to Docker daemon  11.84MB
Step 1/26 : FROM golang:alpine as builder
 ---> 33fbbc2ca571
Step 2/26 : COPY . /go/src/github.com/concourse/semver-resource
 ---> 5d76a755b182
Step 3/26 : ENV CGO_ENABLED 0
 ---> Running in 930ca069ef1a
Removing intermediate container 930ca069ef1a
 ---> 00adab322ce8
Step 4/26 : RUN go build -o /assets/in github.com/concourse/semver-resource/in
 ---> Running in 2a3e5b7fbe42
Removing intermediate container 2a3e5b7fbe42
 ---> 59d8aedbe8ae
Step 5/26 : RUN go build -o /assets/out github.com/concourse/semver-resource/out
 ---> Running in 898caed20147
Removing intermediate container 898caed20147
 ---> 316321747523
Step 6/26 : RUN go build -o /assets/check github.com/concourse/semver-resource/check
 ---> Running in 5751eaf85506
Removing intermediate container 5751eaf85506
 ---> 95f5060b34b4
Step 7/26 : WORKDIR /go/src/github.com/concourse/semver-resource
 ---> Running in 04c554dd7213
Removing intermediate container 04c554dd7213
 ---> c81bc28d69f8
Step 8/26 : RUN set -e; for pkg in $(go list ./...); do                 go test -o "/tests/$(basename $pkg).test" -c $pkg;      done
 ---> Running in b2ba7670bf35
go: downloading github.com/blang/semver v2.1.0+incompatible
go: downloading github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: downloading github.com/aws/aws-sdk-go v1.8.35
go: downloading cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: downloading google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: extracting github.com/blang/semver v2.1.0+incompatible
go: extracting github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: extracting cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: downloading github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: extracting github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: extracting google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: extracting github.com/aws/aws-sdk-go v1.8.35
go: downloading golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: downloading google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: extracting google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: extracting golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: downloading google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: extracting google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: downloading github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: downloading golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: extracting github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: downloading github.com/golang/protobuf v1.3.1
go: extracting golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/go-ini/ini v1.8.6
go: downloading github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: extracting github.com/golang/protobuf v1.3.1
go: extracting github.com/go-ini/ini v1.8.6
go: extracting github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: extracting golang.org/x/text v0.3.2
go: finding github.com/blang/semver v2.1.0+incompatible
go: finding cloud.google.com/go v0.12.1-0.20170831101736-2b74e2e25316
go: finding golang.org/x/net v0.0.0-20190603091049-60506f45cf65
go: finding github.com/googleapis/gax-go v0.0.0-20170824001441-2cadd475a3e9
go: finding google.golang.org/genproto v0.0.0-20170818010345-ee236bd376b0
go: finding google.golang.org/grpc v1.2.1-0.20170831175909-8233e124e463
go: finding github.com/aws/aws-sdk-go v1.8.35
go: finding github.com/golang/protobuf v1.3.1
go: finding github.com/go-ini/ini v1.8.6
go: finding github.com/rackspace/gophercloud v1.0.1-0.20160229015950-f3d053460f7c
go: finding google.golang.org/api v0.0.0-20170901000407-955a3ae66b42
go: finding github.com/jmespath/go-jmespath v0.0.0-20151208071831-c01cf91b0118
go: finding github.com/mitchellh/mapstructure v0.0.0-20160212031839-d2dd02622084
go: finding golang.org/x/oauth2 v0.0.0-20170807180024-9a379c6b3e95
go: finding golang.org/x/text v0.3.2
go: downloading github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
go: downloading github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: downloading github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: extracting github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: extracting github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
go: extracting github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: finding github.com/onsi/ginkgo v1.2.1-0.20160314195341-c3a655f9b37a
go: finding github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: finding github.com/onsi/gomega v0.0.0-20160305213952-7ce781ea776b
?       github.com/concourse/semver-resource/models     [no test files]
Removing intermediate container b2ba7670bf35
 ---> e6cc2c02b491
Step 9/26 : FROM alpine:edge AS resource
 ---> 7eacb6761fa1
Step 10/26 : RUN apk add --no-cache bash tzdata ca-certificates git jq openssh
 ---> Using cache
 ---> c33dfba8feca
Step 11/26 : RUN git config --global user.email "git@localhost"
 ---> Using cache
 ---> c8477ddc2593
Step 12/26 : RUN git config --global user.name "git"
 ---> Using cache
 ---> d7e2ff60741a
Step 13/26 : COPY --from=builder assets/ /opt/resource/
 ---> Using cache
 ---> bd19df4bd34f
Step 14/26 : RUN chmod +x /opt/resource/*
 ---> Using cache
 ---> 37ff74880676
Step 15/26 : FROM resource AS tests
 ---> 37ff74880676
Step 16/26 : ARG SEMVER_TESTING_ACCESS_KEY_ID
 ---> Using cache
 ---> f4e94097a9c1
Step 17/26 : ARG SEMVER_TESTING_SECRET_ACCESS_KEY
 ---> Using cache
 ---> 82e10a5ed0d6
Step 18/26 : ARG SEMVER_TESTING_BUCKET
 ---> Using cache
 ---> a9619215c550
Step 19/26 : ARG SEMVER_TESTING_REGION
 ---> Using cache
 ---> 90f4184fa85f
Step 20/26 : ARG SEMVER_TESTING_V2_SIGNING
 ---> Using cache
 ---> 32461c45c038
Step 21/26 : COPY --from=builder /tests /go-tests
 ---> Using cache
 ---> 030baca992d5
Step 22/26 : WORKDIR /go-tests
 ---> Using cache
 ---> 598b87a1253d
Step 23/26 : RUN set -e; for test in /go-tests/*.test; do               $test;  done
 ---> Using cache
 ---> 5ca4c0c27045
Step 24/26 : COPY test/ /opt/resource-tests
 ---> Using cache
 ---> 759ee4b9831a
Step 25/26 : RUN /opt/resource-tests/all.sh
 ---> Using cache
 ---> 31489e48d068
Step 26/26 : FROM resource
 ---> 37ff74880676
Successfully built 37ff74880676
Successfully tagged semver-resource:latest
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. All files and directories added to build context will have '-rwxr-x
r-x' permissions. It is recommended to double check and reset permissions for sensitive files and directories.
jamieklassen commented 4 years ago

Sorry for not responding to this PR earlier, but this repo has since been converted to use go modules, so hopefully your concerns have been addressed!