concourse / semver-resource

automated semantic version bumping
Apache License 2.0
97 stars 105 forks source link

[BUG] final bump from RC doesn't print bump information #116

Open bruce-ricard opened 4 years ago

bruce-ricard commented 4 years ago

This code works well for me in every case I've tested it, except for when trying to bump final an input of the type 1.2.3-rc.1. The resource appears to bump correctly to 1.2.3 when I look at the next steps of the job, but it does NOT print the exptected

bumped locally from 1.2.3-rc.1 to 1.2.3

Which makes it look like the input version was NOT bumped.

It's possible that this compare function isn't doing the right thing. But both the tests and the code seem pretty convincing to me at first glance.

cc: @adobley