skip_ssl_verification source config not working for git driver - Githubissues

concourse / semver-resource

automated semantic version bumping

Apache License 2.0

97 stars 105 forks source link

skip_ssl_verification source config not working for git driver #145

Open ym294 opened 8 months ago

ym294 commented 8 months ago

Describe the bug

When trying to use "skip ssl verification" option for git driver in semver Resource type for concourse a GO error occurs:

fatal: bad boolean config value "'false'" for http.sslVerify

I believe this is caused by the syntax on line 181 in /driver/git.go of this repo:

181: gitSkipSSLVerification := exec.Command("git", "config", "--global", "http.sslVerify", "'false'")

where the false string is in single quotes surrounded by double quotes.

Reproduction steps

Initialise a semver resource in Concourse YAML config with "skip_ssl_verification: true"
Run in pipeline ...

Expected behavior

The resource should check and initialise without the need for SSL verification when using the git driver in the semver resource.

Additional context

No response