search

concourse / semver-resource

automated semantic version bumping
Apache License 2.0
97 stars 105 forks source link

adding support to skip ssl validation #50

Closed calebwashburn closed 6 years ago

calebwashburn commented 6 years ago

Addresses issue https://github.com/concourse/semver-resource/issues/49

jtarchie commented 6 years ago

@calebwashburn, thanks for the PR!

  1. Are you able to provide tests for this feature?
  2. Can you confirm that the HttpClient used with AWS (before this PR) was DefaultClient? The DefaultClient has really bad timeout default, I want to believe that AWS didn't go with those defaults.

Cheers!

calebwashburn commented 6 years ago

@jtarchie I'll add some tests and run down the 2nd question as well.

calebwashburn commented 6 years ago

@jtarchie added some tests and validated that AWS sdk just uses DefaultClient. This is also the same code used in s3-resource https://github.com/concourse/s3-resource/blob/master/s3client.go#L101-L108

jtarchie commented 6 years ago

Thanks. We'll take a look at this.

vito commented 6 years ago

thanks!