out responds with a models.InResponse

concourse / time-resource

a resource for triggering on an interval

Apache License 2.0

44 stars 32 forks source link

out responds with a models.InResponse #37

Closed mdb closed 5 years ago

mdb commented 5 years ago

out returns a models.InResponse on line 18 of out/main.go, despite that the tests make assertions on what is json.Unarshal'd to a models.OutResponse on line 67 of out/out_test.go.

Technically, this does not impact functionality, as models.InResponse and models.OutResponse are similar. Nonetheless, it's a bit confusing for the reader and is presumably a typo.

mdb commented 5 years ago

This is fixed, as PR #38 was merged. Thanks!