search

concourse / time-resource

a resource for triggering on an interval
Apache License 2.0
44 stars 33 forks source link

Either interval, start, or stop are required and documentation should be updated. #44

Closed jason-riddle closed 4 years ago

jason-riddle commented 5 years ago

The readme mentions that interval, start, and stop are all optional, but the code shows otherwise.

https://github.com/concourse/time-resource/blob/e5a6a93ea3cf550cf09288a250330fc6ceecc597/models/models.go#L50-L52

Either one of interval, start, or stop are required and the readme should reflect this.

jason-riddle commented 5 years ago

Actually from looking at

https://github.com/concourse/time-resource/blob/e5a6a93ea3cf550cf09288a250330fc6ceecc597/models/models.go#L50-L60

It looks like if interval is not set, then both start and stop need to be set.