[ODHack 5.0] Remove Concrete dependency from core/state

[therealbytes]

[ODHack 5.0] Contributors: Note that we highly recommend that you comment on the issue by introducing yourself and how you plan on tackling the issue! Just saying you want an issue is not helpful. This will help with assigning tasks, especially if many comment.

Rationale

Concrete is not actually used by core/state but it is imported by statedb.go for interface checking var _ cc_api.StateDB = (*StateDB)(nil) and argument typing concretePrecompiles concrete.PrecompileMap. This is unfortunate since it makes it impossible to import state from concrete and concrete/api where it would be useful for testing since that would lead to an import cycle error.

Implementation

• The interface check should be moved somewhere else. Probably concrete/api/interface_go.go.
• concretePrecompiles concrete.PrecompileMap should be replaced by an alternative type such as []common.Address or map[common.Address]interface{} and all of the calls to the modified functions be updated accordingly.

[Jemiiah]

@therealbytes i would love to work on this

[therealbytes]

Any news on this? @Jemiiah

[Jemiiah]

hello @therealbytes I’m still working on this at least before Wednesday ends I would create my PR🙌🏾 thank you

[therealbytes]

What's your status on this? @Jemiiah

[Jemiiah]

Hello @therealbytes i will give you feedback later today🙌🏾

[Josh-121]

Hello. I'm looking to make my first contribution here. I'll review the codebase while taking note of the highlighted implementation, I've had some experience working on something similar and looking to complete within 2days if assigned

[therealbytes]

@Josh-121 Any updates?

[Shoetan]

Hi @therealbytes can I be assigned this issue to solve import cycle problem which can be explained simply like

A imports B B imports A

[Josh-121]

@Josh-121 Any updates? Will make pr soon

[Josh-121]

@therealbytes You can unassign by tomorrow if not ready. Sorry for the delay

[therealbytes]

Hey @Josh-121 This is blocking @Shoetan and it has been a week already.

ODHack ends this Sunday. If you are going to do deliver please do it soon enough that @Shoetan has time to finish his work on time. If you don't plan on delivering, it's ok but please let us know now so someone else can do it.

[Josh-121]

On my system now. Should see in some minutes

[Josh-121]

PR is ready