Open alecmolloy opened 4 years ago
I would like to add that aside from solving this particular issue, I would also like to solve the more general problem of users being incapable of stopping code from running automatically.
This no longer breaks the editor. I believe it was likely solved with my recent PR around error handling (#341).
I would also like to solve the more general problem of users being incapable of stopping code from running automatically.
Yeah, agreed. I did mention previously about passing a flag as a URL param to explicitly open a project in safe mode. It would be easy to do, though it's pretty opaque, but then maybe that's enough for us right now? Ideally you should be able to do it via the editor...
Edit to clarify - this no longer breaks the editor, but this code does fail to run on the canvas.
STR:
react-three-fiber
andthree
into fresh projectexpected: app should not work, but error should be displayed actual: editor crashes, restarting browser window causes crash to happen again. no way to repair project.
I'm obviously not as interested in fixing this particular issue as i am interested in understanding how our protection services have failed to work here.