concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Version 2.4.8.2 Doesn't seem to contain the changes #703

Closed mdius closed 1 year ago

mdius commented 1 year ago

It appears that Version 2.4.8.2 is the same as the previous 2.4.7.8.

Mesuva commented 1 year ago

When I unzip the copy attached to the latest release, I'm seeing 2.4.8.2 as the version in the main controller.php file, as well as recently added files (like ProductType.php)

Is there some particular change you are looking for, or are you not seeing 2.4.8.2 as the version number?

mdius commented 1 year ago

Yes, the version it shows is 2.4.8.2, but when I look at the changed files, they are the same as the older version.

Like the files: blocks\community_product_filter/controller.php blocks\community_product_filter/db.xml blocks\community_product_filter/edit.php blocks\community_product_filter/view.php

All the files I looked at so far were the same as the previous version. I re-downloaded the new release and it is the same, was hoping maybe I did something when unzipping it. I am assuming this release was to include the Add product list and filter block filtering by product type?

Mesuva commented 1 year ago

No, the product list and filter block filtering by product type actually isn't quite in the 2.4.8.2 release - that was added shortly after I made the release. It'll be added soon in 2.4.8.3.

Would that perhaps then explain what you're seeing?

mdius commented 1 year ago

Oh, I see what I did, I assumed since they were released 3 days ago (at the time the update and the file change notes in GitHub were 3 days). So, yes, that would explain it. I am very sorry about that. I did a lot of customizing and when I get an update I go through your change log and compare.

Mesuva commented 1 year ago

No worries at all, I'd rather you ask - easy for me to mix up files, I've done this before!