search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Feature/include order attributes in export #728

Closed danklassen closed 1 year ago

danklassen commented 1 year ago

This PR adds any order attributes to the CSV export of the orders report.

I'm not sure if this is desired for all scenarios or not, but for a project we're working on it is necessary and I thought others may benefit from this too.

Mesuva commented 1 year ago

I reckon this is very useful, as often those extra attributes are critical to how someone has set up a shop.

I'm planning to do a bit of work on order attributes in general next week, I'll re-review and merge this then. Thank you.

danklassen commented 1 year ago

thanks!

I see I actually included the commit from #727 in this as well. I must have created this feature branch off of my other one instead of master. When you have a chance let me know if you want me to resubmit with just the one commit.

Mesuva commented 1 year ago

I did see that same code, but that shouldn't be a problem at all, no need for a resubmit

Mesuva commented 1 year ago

I've merged this in, thanks again, I reckon this is really handy