search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

select2 installed to js folder instead of vendor #745

Closed mlocati closed 1 year ago

mlocati commented 1 year ago

Is there any reason to install select2 as a composer package?

Why? For example, let's assume that we start with a composer-based Concrete project like this.

If we add concrete5-community-store/community_store as a composer dependency, the package will be installed in

/web/packages/community_store

(that is, under the web webroot), but its dependencies will be installed in

/vendor

(that is, outside the webroot).

But Community Stores assumes that the composer dependencies are installed under

/web/packages/community_store/vendor

The solution is simply to remove select2 from the composer dependencies, and install it exactly the same way we already install other npm packages.

Mesuva commented 1 year ago

I can't remember the reason for this. It may have been to do with packaging up releases.