search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Product filter counts for product types #761

Closed danread33 closed 1 year ago

danread33 commented 1 year ago

Just found a small issue with the product filter block when filtering on product types. The counts next to each filter attribute are not reflecting the chosen product type and seem to be counting all product types.

Looks like it just needs the product type set in the view method in the product filter controller here /packages/community_store/blocks/community_product_filter/controller.php

I just added this at line 260 and it seems to fix it. $products->setProductType($this->filterProductType);

I think I'm pushing community cart to the limit on our recent build, lots of product type and variation functionality :)

Mesuva commented 1 year ago

Thank you for this - I haven't forgotten to review this, I'm just trying to cue up my next burst of work on Community Store.

Mesuva commented 1 year ago

This will be in the next release