concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

export-ignore development stuff #764

Closed mlocati closed 1 year ago

mlocati commented 1 year ago

When downloading the .zip file from the releases page, we have a ton of files that are only useful for development.

What about excluding them from the .zip files that are automatically generated by git (and github)?

If people still want the full repository contents, they can still do a git clone

mlocati commented 1 year ago

PS: to see what this PR implies, simply try to download https://codeload.github.com/mlocati/community_store/zip/refs/heads/export-ignore

Mesuva commented 1 year ago

Sure, not seeing any issue with that. I actually wish it didn't generate automatic zips like that, I just want to attach my release zip and offer that...

mlocati commented 1 year ago

Sure, you still have to provide a manually built .zip file, because people that don't use composer simply need the vendor stuff.

But I install community_store via composer, with something like this in my composer.json file:

{
    "require": {
        "concrete5-community-store/community_store": "^2.5"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/concretecms-community-store/community_store.git"
        }
    ]
}

With this .gitattributes file, if I install the composer packages with --prefer-dist I don't have any unneeded file published in the production server.

PS: if we close https://github.com/concretecms-community-store/community_store/issues/748 I can also remove the repositories section :wink:.