search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Add support for external payment methods that use GET instead of POST #770

Closed mlocati closed 1 year ago

mlocati commented 1 year ago

The new payment method I'm developing, requires invoking an external URL via GET instead of POST.

With this change, payment method controllers can override the new isExternalActionGET() method: if it returns true, the URL returned by the getAction() method will be called via GET instead of POST.

Mesuva commented 1 year ago

Sounds good to me, makes this a lot clearer.

Going forward, I think the POST method (which was primarily used by the Paypal Standard payment method) will only really be used for legacy situations. The new Paypal Checkout method I've released doesn't use that mechanism any more, and it was always a bit open to manipulation.