search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Rename composer package #772

Closed mlocati closed 1 year ago

mlocati commented 1 year ago

Better to do it now, before someone starts using Community Store via Composer.

Mesuva commented 1 year ago

Yep, I've made this change locally. There's also the type, which I'm not 100% sure if it's valid to be: "type": "concretecms-package",

But that's what I'll be changing it to, unless you can advise otherwise.

mlocati commented 1 year ago

Nope, we can't change the type, otherwise Composer won't install it in the right location (that is, in the packages directory instead of under the vendor directory) - see https://github.com/composer/installers/blob/main/src/Composer/Installers/Concrete5Installer.php

Mesuva commented 1 year ago

Interesting! I'll be looking into Packagist as well as your github action suggestion soon. Really appreciate your involvement here.

mlocati commented 1 year ago

We'd need this change in order to use concretecms-package instead of concrete5-package (and we have to wait for a new composer/installers release).