search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Display original price when discounts are applied #796

Closed mlocati closed 1 year ago

mlocati commented 1 year ago

Let's assume we have:

  1. a product group named "10% off"
  2. a discount of 10% for all the product in the "10% off" group
Product Before After
Price : 100
Sale price: empty
Groups: none		 immagine immagine
Price : 100
Sale price: 90
Groups: none		 immagine immagine
Price : 100
Sale price: empty
Groups: 10% off		 immagine immagine

See the difference in the Product C.

Fix #794

mlocati commented 1 year ago

@Mesuva any reason to keep this PR on hold?

I'm not asking you to hurry up, I simply like to know if you see something wrong. (We are using it in production and everything seems ok so far, but I'm not 100% sure it's correct: I'm still pretty new about Community Store)

Mesuva commented 1 year ago

@mlocati No reason at all, I just didn't have the opportunity to review this and the related issue - there's a bit more to think about with this one than other fixes, so I didn't want to just merge it without giving it some brain power.

mlocati commented 1 year ago

Yep, 4 eyes are always better than 2... thanks for all the time you spend on this great project!