search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Add contexts to "Sale" translatable strings #803

Closed mlocati closed 11 months ago

mlocati commented 1 year ago

I added a context and a note for translators in all the translatable strings that contain "sale": that way it will be clear if "sale" refers to discounting or to selling.

Of course, a review by a native speaking developer is much appreciated (guess who am I talking about? :wink:)

Close #795

mlocati commented 1 year ago

@Mesuva is there any problem with this PR?

Mesuva commented 1 year ago

No problems at all - I had just left some items to review, those should be above. It was really just whether you wanted to adjusts the translation prompts based on my feedback.

mlocati commented 1 year ago

[...] those should be above [...] [...] based on my feedback [...]

I'm sorry, but I don't know to which feedback you are referring to...

mlocati commented 1 year ago

Maybe you started the review in GitHub but didn't "publish" your notes? I don't see any...

Mesuva commented 1 year ago

Oh weird, try that now. I reckon github is a bit different to the last time I used the 'review' feature.

mlocati commented 1 year ago

Oh weird, try that now. I reckon github is a bit different to the last time I used the 'review' feature.

Yep, now I see them!

mlocati commented 1 year ago

I've rebased this PR and added https://github.com/concretecms-community-store/community_store/pull/803/commits/40b5bcac5d798a3f8b598be882e314e9c41cde1f

mlocati commented 11 months ago

@Mesuva what about this PR?

Mesuva commented 11 months ago

I must have just missed this one, sorry!

mlocati commented 11 months ago

No problem! And thank you!!