search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Upgrade package version number #809

Closed mlocati closed 10 months ago

mlocati commented 10 months ago

When fetching the translations from translate.concretecms.org, Concrete passes it the package version (this is required in order to fetch the translations for the currently installed package version).

At the moment, the package version is 2.6.0, and because there's a git tag associated to it, in translate.concretecms.org there's the an exact version corresponding to it.

So, translate.concretecms.org provides the translations for version 2.6.0.

But what happens if we have the latest master installed? The translatable strings in the package are newer, but translate.concretecms.org still provides the older ones.

The solution? Define a package version in master that's greater than the latest tag. That way, translate.concretecms.org will provide the strings for the "2 development series" (which comes from master).

Mesuva commented 10 months ago

So does that mean that every time we do a release, I should set the version number to something for the release, then do the release, and immediately after update the package version something greater?

mlocati commented 10 months ago

So does that mean that every time we do a release, I should set the version number to something for the release, then do the release, and immediately after update the package version something greater?

Yep: see https://github.com/concretecms-community-store/community_store/pull/811