search

concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
106 stars 66 forks source link

Make Multilingual utility a singleton #868

Closed mlocati closed 3 months ago

mlocati commented 3 months ago

With

$app->singleton('cs/helper/multilingual', Utilities\Multilingual::class);

we make 'cs/helper/multilingual' a singleton, but Utilities\Multilingual is not a singleton (which is not good for Dependency Injection).

What about making Utilities\Multilingual a singleton and 'cs/helper/multilingual' an alias of it?

$app->singleton(Utilities\Multilingual::class);
$app->alias('cs/helper/multilingual', Utilities\Multilingual::class);