concretecms-community-store / community_store

An open, free and community developed eCommerce system for Concrete CMS
https://concretecms-community-store.github.io/community_store/
MIT License
105 stars 66 forks source link

Don't show Guest group in allowed/disallowed groups for payment methods #874

Closed mlocati closed 4 months ago

mlocati commented 4 months ago

I'm working on the code of a payment method.

In order to test it in the production website. I wanted to prevent non registered users from using it.

For that reason, I've added the Guests to the "Exclude From User Groups" settings. But with that setting, even administrators weren't seeing the payment method.

The reason? Every site visitor is a member of the Guest user group (yep, both registered and not registered users - see here).

So, choosing "Guests" actually means "Always", but it's really misleading.

What about simply removing "Guests"?

Mesuva commented 4 months ago

Totally agree!