search

concretecms / addon_migration_tool

Repository for the concrete5 Migration tool (legacy and modern versions.)
27 stars 25 forks source link

Add PageListImporter with defaults #58

Closed fabian closed 6 years ago

fabian commented 6 years ago

When importing a Page List block from concrete5 5.6.4.0, I noticed the new options "Include Name" and "Include Page Description" are always turned off and the Page List block appears empty in version 8.3.2 after the import.

Looking at the code of the block, the default values are only set in the add view:

https://github.com/concrete5/concrete5/blob/fa1ab2d331623d545968b8e1bec0dd5ef91f04cd/concrete/blocks/page_list/controller.php#L236-L237

This pull request sets them during the import of a Page List block. No idea if this is the right way to implement it, but it works.

fabian commented 6 years ago

Nevermind my previous comment about the issue with listing pages below the current page, I was able to fix that by exporting the parent pages as well. The pull request is still valid though.